fix: update kafee consumer handle_failure/2 fn #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msutkowski
reviewed
Nov 12, 2024
msutkowski
approved these changes
Dec 13, 2024
parkerd
pushed a commit
that referenced
this pull request
Dec 17, 2024
An automated release has been created for you. --- ## [3.5.1](v3.5.0...v3.5.1) (2024-12-13) ### Bug Fixes * Improve Kafee exception handling ([#126](#126)) ([fa5bd44](fa5bd44)) * Update kafee consumer handle_failure/2 fn ([#119](#119)) ([4c12df7](4c12df7)) ### Miscellaneous * Correct documentation to include start.count metric ([#125](#125)) ([3ab284c](3ab284c)) * Sync files with stordco/common-config-elixir ([#128](#128)) ([3adffb8](3adffb8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
N/A
Checklist
Problem
The built in
Kafee.Consumer.handle_failure/2function raises an error which causes problems down the line. It should instead return an:oklike the behaviour specifies.Details
Change
raise RuntimeErrortoLogger.error