-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add otp_app option to consumer and producer compile-time options to improve configurating the modules #77
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we just make otp_app
required to deal with config loading. That way apps can't invent their own config loading. Might clean up code.
I prefer to use the module scoping rather than relying on global scope such as |
fb900f8
to
eb4d3fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but we will need to set the otp_app for tests
0c98195
to
0a7445a
Compare
…ns to improve configurating the modules
0a7445a
to
dafb878
Compare
@btkostner ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good though this technically is a breaking change and I know there are a couple of services already using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make this a non breaking change by making the option not required and defaulting to []
configuration.
@btkostner that sounds like the way to go 🚀 |
Ran into some issues with config loading and required fields. This will require more work to get it in a releasable state without breaking changes. |
No description provided.