Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix straprc for 2 edge cases #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

charliegetzen-okta
Copy link

Edge case 1 - using an ls alternative

See #7
This is remediated by surfacing errors so folks can see what is going on.

Edge case 2 - using dot files

If you were to put a .test.sh file in straprc.d, it would be picked up by ls -A, however, it would NOT be picked up by for file in "${HOME}"/.strap/etc/straprc.d/*.sh; do
In this scenario, one of two things could happen:

  1. There are only dot-files in straprc.d - this will cause errors because the for-loop globbing will fail
  2. There are regular files and dot-files - The dot files will be ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant