Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to cover all unformatted UUID commands #3610

Merged
merged 1 commit into from
May 7, 2024

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented May 6, 2024

Closes #3604
Related #3299

@mulkieran mulkieran self-assigned this May 6, 2024
@mulkieran
Copy link
Member Author

I believe that it is also possible not just to test but to make these into parser errors.

@mulkieran mulkieran force-pushed the issue_stratisd_3604 branch 6 times, most recently from e2f7171 to 03ac26a Compare May 7, 2024 18:09
@mulkieran mulkieran marked this pull request as ready for review May 7, 2024 19:36
@mulkieran mulkieran force-pushed the issue_stratisd_3604 branch from 03ac26a to 090b5d7 Compare May 7, 2024 19:46
@mulkieran mulkieran requested a review from bgurney-rh May 7, 2024 19:47
@mulkieran mulkieran merged commit bca4df0 into stratis-storage:master May 7, 2024
23 checks passed
@mulkieran mulkieran deleted the issue_stratisd_3604 branch May 7, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For stratis-min, failure to scan a UUID when a UUID is expected should really be a parsing error
2 participants