-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framable (iframe); rebust responsiveness and refactored mobile view #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will need love, i.e. the responsiveness. It's gonna be better tho. We're prepping to support query string display params.
Now it doesn't stand out and confuse the user that it's 0 results for nodes.
Nothing worse than not knowing wtf is going on, smh! Expect breaking changes here.
This improves overall UX for the sidebar on both small and large screens. - Active view changes to "Map" more reliably and at an accurate moment. - On mobile clicking items in the search result actually take the user to the clicked item. Previously it'd contract the list and do nothing more. - Sidebar is more CSS-driven rather than JS-driven altho js is still there (gotta be). Certain in-JS calculations are gone for good tho.
It decreased padding.
Had to be restructured completely for reasonable outcome. Looks like I nailed it! Vertically and horizontally responsive. Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few things happened here:
iframe
and it'll behave as instructed (there are options).iframe
does not pollute host's history (odd thing in general) – lmk if you wanna know more.This and many many more improvements.
HUD options one can use to embed a perfect Explorer onto their site:
Sum of desired options has to be passed via the
?hud=
GET param.For example, to open the explorer with
http://localhost:3000/?hud=448
Devs can experiment with each of these in the Storybook (
npm run storybook
).