Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
KeyServer
, usinggenerateWalletWithGasAndTokens()
instead offetchPrivateKeyWithGas()
TODO:
fastPrivateKey()
)fetchPrivateKeyWithGas()
Benchmark
Seems that this decreases test runtime. But run tests multiple times to ensure that. Current results:
node-e2e
: 367s -> 346sOther changes
Commit 8ee7a8a could be a separate PR
Moved
generateWalletWithGasAndTokens()
totest-utils
. That commit could be a separate PR 5d68316Note
setupOperatorContract()
needsgenerateWalletWithGasAndTokens(
) because that method is in theory "production code" andgenerateWalletWithGasAndTokens()
is test code. In practicesetupOperatorContract()
is test code -> we don't need this hack if we refactorsetupOperatorContract()
to be a test utility (i.e. not inoperatorContractUtils
)Future improvements
Maybe
retry()
logic is not needed ingenerateWalletWithGasAndTokens()
?