Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Query neighbors by stream #15

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

teogeb
Copy link
Collaborator

@teogeb teogeb commented Mar 20, 2024

Support this kind of query:

neighbors(stream: "stream") {
  items {
    streamPartId
    nodeId1
    nodeId2
  } 
}

Note that if a nodes are neighbors in multiple stream parts, multiple items will be returned. E.g.:

stream#0, A, B
stream#1, A, B

Also improved API server unit test coverage by using duplicate nodeIds in some test topologies.

@teogeb teogeb requested review from mondoreale and harbu March 20, 2024 16:21
Copy link

@mondoreale mondoreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@teogeb teogeb merged commit d10dc9f into query-nodes-by-stream Mar 21, 2024
3 checks passed
teogeb added a commit that referenced this pull request Mar 21, 2024
Support this kind of query:
```graphql
neighbors(stream: "stream") {
  items {
    streamPartId
    nodeId1
    nodeId2
  } 
}
```

Note that if a nodes are neighbors in multiple stream parts, multiple items will be returned. E.g.:
```
stream#0, A, B
stream#1, A, B
```

Also improved API server unit test coverage by using duplicate nodeIds in some test topologies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants