-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mobile, update zh-CN locales #488
base: main
Are you sure you want to change the base?
Conversation
I don't have permission to add translation in LocaleApp, how to participate in? |
Will this close #464? |
@duenni No, but I can fix it in next commit. If you device has very small screen(eg: IPhone 4), the layout may broken. |
@duenni I just blamed the stylesheets source code, it shows the font-size not change in the last 5 years. |
No, I did not try other devices. It's an iPhone SE, resolution should be 1136 x 640 px. |
@guyskk I know it's been a couple of years, but are you still available to work on this? If so, I think it would be good to break up into separate PRs. One for the translations, one for the layout cleanups, and one for Turbolinks. I'm a little concerned about Turbolinks in particular, as that can cause issues depending on how the JavaScript is set up. |
Hi @mockdeep, I didn't use stringer for a long time, and I have build another RSS reader https://github.com/anyant/rssant . Please feel free to use my code and commits if you need. |
@guyskk okay, I'll handle it, then. Thanks so much for contributing! |
@mockdeep would love to have those css fixes merged. Should I take over the fixing of this pr? |
@bitboxer that would be great! If you want to separate out the CSS changes, I'll be happy to review them and get them merged. |
Before:
After: