Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added contributing docs and github workflows standard #10

Merged
merged 9 commits into from
Apr 18, 2024
Merged

Added contributing docs and github workflows standard #10

merged 9 commits into from
Apr 18, 2024

Conversation

hemantwasthere
Copy link
Contributor

Fixes: #7

This PR fixes 2nd and 3rd steps of Issue (#7)

@hemantwasthere
Copy link
Contributor Author

Hey @akiraonstarknet please review it once ser!

Copy link

gitguardian bot commented Apr 18, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 39c2aea src/app/template.tsx View secret
- Generic High Entropy Secret 793e86d src/app/template.tsx View secret
- Generic High Entropy Secret 793e86d src/app/template.tsx View secret
- Generic High Entropy Secret 39c2aea src/app/template.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@akiraonstarknet akiraonstarknet merged commit 3601776 into strkfarm:dev Apr 18, 2024
1 check failed
@akiraonstarknet
Copy link
Contributor

@all-contributors please add @hemantwasthere for Project docs and github flows setup

@akiraonstarknet
Copy link
Contributor

@all-contributors please add @hemantwasthere for infra

Copy link
Contributor

@akiraonstarknet

I've put up a pull request to add @hemantwasthere! 🎉

akiraonstarknet added a commit that referenced this pull request Jul 29, 2024
add vercel speed analytics (#74)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup docs and contribution standards
2 participants