Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokens): add support for sSTRK token and pools #197

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

0xdevcollins
Copy link

PR Fixes:

  • 1 Added Dex pools for sSTRK listed on Ekubo and Nostra.
  • 2 Integrated DeFi Spring rewards for sSTRK into Ekubo and Nostra codebase.

Resolves #190

Vercel website link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue
  • My PR passes all checks (build, lint, formatting, etc)

@0xdevcollins
Copy link
Author

I get this error when I build
image

@akiraonstarknet
Copy link
Contributor

@0xdevcollins there error could be bcz of improper env variables.
@EjembiEmmanuel can help

@akiraonstarknet
Copy link
Contributor

@0xdevcollins
I dont think STRK Staking pool (sSTRK) by Nimbora is added. Even that needs to be added. Check endur protocol for reference.

Second, sSTRK pool on Vesu and Nostra (Lending/borrow) is not added.

@akiraonstarknet akiraonstarknet self-requested a review December 23, 2024 09:56
@@ -175,6 +175,9 @@ export class Ekubo extends IDapp<EkuboBaseAprDoc> {
'USDT',
'ETH',
'STRK',
'sSTRK/USDC',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be SSTRK not sSTRK

@@ -175,6 +175,9 @@ export class Ekubo extends IDapp<EkuboBaseAprDoc> {
'USDT',
'ETH',
'STRK',
'sSTRK/USDC',
'sSTRK/ETH',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@@ -175,6 +175,9 @@ export class Ekubo extends IDapp<EkuboBaseAprDoc> {
'USDT',
'ETH',
'STRK',
'sSTRK/USDC',
'sSTRK/ETH',
'sSTRK',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@@ -77,6 +85,19 @@ const CONSTANTS = {
};

export const TOKENS: TokenInfo[] = [
{
token: standariseAddress(
'0x0260c02fd6942c788b8905d2c1b98b5a98fffd2ec0dfb013aa4b148781e269b6',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The token contract address should be 0x0356f304b154d29d2a8fe22f1cb9107a9b564a733cf6b4cc47fd121ac1af90c9

@EjembiEmmanuel
Copy link
Collaborator

Please deploy your app on Vercel and provide the link in the description

@EjembiEmmanuel
Copy link
Collaborator

@0xdevcollins any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add sSTRK DEX pools
3 participants