Integrated Vesu.xyz protocol #97
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10294468 | Triggered | Generic High Entropy Secret | 217659a | src/app/slinks/template.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
src/store/vesu.store.ts
Outdated
| const getUtilisation = async (poolId: string, tokenAddress: string) => { | ||
| const contract = new Contract( | ||
| VesuAbi, | ||
| '0x02545b2e5d519fc230e9cd781046d3a64e092114f07e44771e0d719d148725ef', |
There was a problem hiding this comment.
create a constant variable with appropriate name for this contract address and use this variables instead of hardcoding
src/store/vesu.store.ts
Outdated
| '2198503327643286920898110335698706244522220458610657370981979460625005526824', | ||
| tokenAddress: | ||
| '0x049d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7', | ||
| rewardApr: '0.09', |
There was a problem hiding this comment.
u hardcoded rewardAPR. wrong.
src/store/vesu.store.ts
Outdated
| '0x4718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d', | ||
| rewardApr: '0.13', | ||
| baseApr: '0', | ||
| tvl: '2000000', |
There was a problem hiding this comment.
TVL also hardcoded. Wrong.
src/store/vesu.store.ts
Outdated
| }, | ||
| ], | ||
| category, | ||
| type: PoolType.DEXV2, |
There was a problem hiding this comment.
PoolType is Lending.
| description: '', | ||
| }, | ||
| ], | ||
| category, |
There was a problem hiding this comment.
Category is not stable for all pools
| export class Vesu extends Jediswap { | ||
| name = 'Vesu'; | ||
| link = 'https://www.vesu.xyz/markets'; | ||
| logo = |
There was a problem hiding this comment.
Incorrect url. i will provide correct one.
|
Closed in favour of #142 |
PR Fixes:
Here is what it looks like
Resolves #79
Vercel website link
Checklist before requesting a review