Discord.js upgrade #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 6, 2023 21:18
to enable slash commands
silasary
requested changes
Oct 9, 2023
src/utils/discord.ts
Outdated
| if (message instanceof CommandInteraction) { | ||
| if (message.guild && !message.guild.roles.everyone.permissionsIn(message.channel! as NonThreadGuildBasedChannel).has('UseExternalEmojis')) { | ||
| if (message instanceof CommandInteraction) { | ||
| if (message.guild && (!message.guild.roles.everyone.permissionsIn(message.channel! as NonThreadGuildBasedChannel).has('UseExternalEmojis') || !message.guild?.members.me?.premiumSince)) { |
There was a problem hiding this comment.
Bots implicitly have a nitro-like ability to use external emoji, but technically don't have nitro. This check will break things.
There was a problem hiding this comment.
This was the only way that I could get emojis to show up. It would appear that the bot does not have those permissions?
There was a problem hiding this comment.
I will double back and look at permissions to confirm. But I have the external emojis on, in my server...
added 16 commits
October 10, 2023 08:39
Covering github bugs: discord/discord-api-docs#5524 discord/discord-api-docs#5279 This seems to apply only to new connections. Older server connections that are already wired up do not have this issue.
added 20 commits
October 21, 2023 01:34
Rehabilitating event reporting tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored to use the upgraded Discord.js libs.