-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add section for FOUC bug in next js 13 #971
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@quantizor please review |
Hi @quantizor, a moment to review this? |
sections/faqs/nextjs-13-issues.mdx
Outdated
```js | ||
/** @type {import('next').NextConfig} */ | ||
const nextConfig = { | ||
reactStrictMode: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strict mode required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's there because I copy-pasted the solution from #927. I can delete it if unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, let me know if I should take out strict mode
Maybe we could update the SSR section that already has next.js instructions? https://styled-components.com/docs/advanced#app-directory |
I think it sits better in the FAQs, instead of the advanced section in https://styled-components.com/docs/advanced#app-directory, as both sets of information don't seem to be directly related. However, having them in the same area is the best for easy access, and I can do that. Do I go ahead? |
@quantizor I'll go ahead and put them in the same section. |
Hi @quantizor, I've moved the changes to the SSR section. Review please |
Hi again 👋🏽 @quantizor. Please review |
Changes
Adds a FAQ solving the flash of unstyled components bug in next js 13
Issue
Closes #927 and #922