fix utility props value type about override the Theme interface

[strozw]

Summary

this PR is fix below issue by add string | number | false into ThemeNamespaceValue (7a430a9).

Fixes #344

and fix type-errors about theme value types in tests files.

Test plan

1. npm install in project root
2. type checking
   • no errors to run npx tsc --noEmit -p ./packages/system
   • no errors to run npx tsc --noEmit -p ./packages/styled-components
   • no errors to run npx tsc --noEmit -p ./packages/emotion
3. pass the tests (run npm test in project root)

[gregberge]

I don't think the fix is correct. ThemeNamespaceValue means a value in the theme namespace, nothing else. However, I see what you want to fix, but I think it is not the right place to do it.

[strozw]

Thank you for your review.
Sure, my fix wasn't fit for name.

Read the code again and investigate the appropriate corrections.

[strozw]

1st, I reverted prev changes, and changed SystemProp insted of ThemeNamespaeceValue for fix utility props. I think this type name means utility props, but what do you think?

• ddf9537

2nd, above changes is not cover same problem about each themeGetter. so I changed ThemeGetter for it.

• 09ea4eb

３rd, the first change on SystemProps found an issue where col and row props didn't support false, so we fixed each one.

• b46291d
• 5375b4c

[gregberge]

I am sorry but it does not make sens at all to authorize anything anywhere. Each prop has its own typing, maybe some are missing, but globally it is good.

[strozw]

@gregberge

thanks for your review.

Each prop has its own typing, maybe some are missing, but globally it is good.

Indeed, I think it should be safe for Typing to be more accurate and limited. This PR will be closed and I'll reconsider if we can contribute in another way.