feat(xmpp) remove support for the deprecated options.bosh

Yeah, > 4 years seems like ample time :-)

modules/xmpp/xmpp.js

@@ -119,7 +119,6 @@ export default class XMPP extends Listenable {
      * @param {Object} options
      * @param {String} options.serviceUrl - URL passed to the XMPP client which will be used to establish XMPP
      * connection with the server.
-     * @param {String} options.bosh - Deprecated, use {@code serviceUrl}.
      * @param {boolean} options.enableWebsocketResume - Enables XEP-0198 stream management which will make the XMPP
      * module try to resume the session in case the Websocket connection breaks.
      * @param {number} [options.websocketKeepAlive] - The websocket keep alive interval. See {@link XmppConnection}
@@ -132,6 +131,11 @@ export default class XMPP extends Listenable {
      */
     constructor(options, token) {
         super();
+
+        if (options.bosh && !options.serviceUrl) {
+            throw new Error('The "bosh" option is no longer supported, please use "serviceUrl" instead');
+        }
+
         this.connection = null;
         this.disconnectInProgress = false;
         this.connectionTimes = {};
@@ -155,9 +159,7 @@ export default class XMPP extends Listenable {
 
         this.connection = createConnection({
             enableWebsocketResume: options.enableWebsocketResume,
-
-            // FIXME remove deprecated bosh option at some point
-            serviceUrl: options.serviceUrl || options.bosh,
+            serviceUrl: options.serviceUrl,
             token,
             websocketKeepAlive: options.websocketKeepAlive,
             websocketKeepAliveUrl: options.websocketKeepAliveUrl,