Skip to content

Commit

Permalink
fix(SS): Reverse the encoding order for Firefox desktop streams. (jit…
Browse files Browse the repository at this point in the history
…si#2384)

Fixes an issue where screenshare from Firefox appears blurry on other endpoints in the call.
  • Loading branch information
jallamsetty1 authored and subhamcyara committed Jul 19, 2024
1 parent 8722732 commit fe6daa5
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion modules/RTC/TPCUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,10 @@ export class TPCUtils {
// The SSRCs on older versions of Firefox are reversed in SDP, i.e., they have resolution order of 1:2:4 as
// opposed to Chromium and other browsers. This has been reverted in Firefox 117 as part of the below commit.
// https://hg.mozilla.org/mozilla-central/rev/b0348f1f8d7197fb87158ba74542d28d46133997
const reversedEncodings = browser.isFirefox() && browser.isVersionLessThan(117);
// This revert seems to be applied only to camera tracks, the desktop stream encodings still have the
// resolution order of 4:2:1.
const reversedEncodings = browser.isFirefox()
&& (videoType === VideoType.DESKTOP || browser.isVersionLessThan(117));

return [
{
Expand Down

0 comments on commit fe6daa5

Please sign in to comment.