address review comment: restore argumentMarker method

substrait-io · Dec 2, 2024 · 402419f · 402419f
1 parent 3f61589
commit 402419f
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/extensions/simple_extension.go b/extensions/simple_extension.go
@@ -59,6 +59,7 @@ type TypeVariation struct {
 
 type FuncParameter interface {
 	toTypeString() string
+	argumentMarker() // unexported marker method
 	GetTypeExpression() types.FuncDefArgType
 }
 
@@ -72,6 +73,8 @@ func (EnumArg) toTypeString() string {
 	return EnumTypeString
 }
 
+func (v EnumArg) argumentMarker() {}
+
 func (v EnumArg) GetTypeExpression() types.FuncDefArgType {
 	return &types.EnumType{Name: v.Name, Options: v.Options}
 }
@@ -87,6 +90,8 @@ func (v ValueArg) toTypeString() string {
 	return v.Value.ValueType.ShortString()
 }
 
+func (v ValueArg) argumentMarker() {}
+
 func (v ValueArg) GetTypeExpression() types.FuncDefArgType {
 	return v.Value.ValueType
 }
@@ -99,6 +104,8 @@ type TypeArg struct {
 
 func (TypeArg) toTypeString() string { return "type" }
 
+func (v TypeArg) argumentMarker() {}
+
 func (v TypeArg) GetTypeExpression() types.FuncDefArgType {
 	return v.Type.ValueType
 }