Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new Remap interface to relations #71

Merged
merged 17 commits into from
Dec 5, 2024

Conversation

EpsilonPrime
Copy link
Member

@EpsilonPrime EpsilonPrime commented Nov 20, 2024

Remap() is an alternative to the current Remap variants currently found on the Builder interface. It preserves the existing behavior including checking the proposed mapping for validity. It also modifies the relation instead of returning a copy. All of the existing Remap function variants have been marked as deprecated in favor of Remap.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 91.78082% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.69%. Comparing base (9b453f5) to head (0178a4f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
plan/relations.go 90.32% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   59.56%   61.69%   +2.12%     
==========================================
  Files          43       44       +1     
  Lines        9316     9781     +465     
==========================================
+ Hits         5549     6034     +485     
+ Misses       3507     3469      -38     
- Partials      260      278      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plan/relations.go Outdated Show resolved Hide resolved
plan/plan.go Outdated Show resolved Hide resolved
plan/relations.go Outdated Show resolved Hide resolved
@EpsilonPrime EpsilonPrime marked this pull request as draft November 22, 2024 07:51
@EpsilonPrime EpsilonPrime force-pushed the remap branch 2 times, most recently from d3171c2 to 33c58f9 Compare November 28, 2024 00:30
@EpsilonPrime EpsilonPrime marked this pull request as ready for review November 28, 2024 00:38
plan/relations.go Outdated Show resolved Hide resolved
plan/plan.go Outdated Show resolved Hide resolved
plan/plan.go Outdated Show resolved Hide resolved
plan/plan.go Show resolved Hide resolved
@EpsilonPrime EpsilonPrime changed the title feat: Add ChangeMapping interface to relations feat: Add new Remap interface to relations Dec 3, 2024
plan/relations.go Outdated Show resolved Hide resolved
plan/relations.go Outdated Show resolved Hide resolved
plan/relations.go Outdated Show resolved Hide resolved
@EpsilonPrime EpsilonPrime merged commit 18803a2 into substrait-io:main Dec 5, 2024
8 checks passed
@EpsilonPrime EpsilonPrime deleted the remap branch December 5, 2024 01:26
@EpsilonPrime EpsilonPrime restored the remap branch December 5, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants