-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new Remap interface to relations #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 59.56% 61.69% +2.12%
==========================================
Files 43 44 +1
Lines 9316 9781 +465
==========================================
+ Hits 5549 6034 +485
+ Misses 3507 3469 -38
- Partials 260 278 +18 ☔ View full report in Codecov by Sentry. |
jacques-n
reviewed
Nov 20, 2024
EpsilonPrime
force-pushed
the
remap
branch
2 times, most recently
from
November 28, 2024 00:30
d3171c2
to
33c58f9
Compare
jacques-n
reviewed
Nov 28, 2024
jacques-n
reviewed
Dec 3, 2024
EpsilonPrime
changed the title
feat: Add ChangeMapping interface to relations
feat: Add new Remap interface to relations
Dec 3, 2024
jacques-n
reviewed
Dec 4, 2024
… NamedDelete also exist).
jacques-n
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remap() is an alternative to the current Remap variants currently found on the Builder interface. It preserves the existing behavior including checking the proposed mapping for validity. It also modifies the relation instead of returning a copy. All of the existing Remap function variants have been marked as deprecated in favor of Remap.