Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a way to get an expr.ExprBuilder from a plan.Builder #81

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

EpsilonPrime
Copy link
Member

By creating anexpr.ExprBuilder directly from the plan.Builder the two can share the same extension registry.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.61%. Comparing base (9b453f5) to head (fada7eb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   59.56%   59.61%   +0.05%     
==========================================
  Files          43       43              
  Lines        9316     9321       +5     
==========================================
+ Hits         5549     5557       +8     
+ Misses       3507     3505       -2     
+ Partials      260      259       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacques-n jacques-n merged commit fd3415c into substrait-io:main Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants