Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add arithmetic function for bitwise not with decimal arguments #676

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add arithmetic function for bitwise not with decimal arguments #676

wants to merge 2 commits into from

Conversation

anshuldata
Copy link
Contributor

@anshuldata anshuldata commented Aug 1, 2024 •
edited
Loading

  • Added definition for bitwise_not
  • For input precision 1, Snowflake returns precision 2. Added a function in function_snowflake.yaml to capture this snowflake specific behavior.
  • Also added test cases to capture expected behavior.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

ACTION NEEDED

Substrait follows the Conventional Commits
specification for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@anshuldata anshuldata force-pushed the anshul/BitwiseNotDecimal branch from 6e2f1d8 to 06f380b Compare August 1, 2024 08:07
@anshuldata anshuldata changed the title add arithmetic function for bitwise not with decimal arguments feat: add arithmetic function for bitwise not with decimal arguments Aug 1, 2024
@anshuldata anshuldata force-pushed the anshul/BitwiseNotDecimal branch from 06f380b to 766c0f6 Compare August 2, 2024 05:22
@jacques-n jacques-n added the awaiting-user-input This issue is waiting on further input from users label Aug 8, 2024
@anshuldata anshuldata force-pushed the anshul/BitwiseNotDecimal branch 4 times, most recently from 1dfc984 to c0d2de9 Compare August 12, 2024 11:46
@anshuldata anshuldata force-pushed the anshul/BitwiseNotDecimal branch from c0d2de9 to 048875e Compare August 12, 2024 11:47
jacques-n
jacques-n approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional test cases would be good but this is a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacques-n jacques-n jacques-n approved these changes

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

@EpsilonPrime EpsilonPrime Awaiting requested review from EpsilonPrime EpsilonPrime is a code owner

@vbarua vbarua Awaiting requested review from vbarua vbarua is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
awaiting-user-input This issue is waiting on further input from users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshuldata @jacques-n