Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.7v #41

Merged
merged 8 commits into from
Dec 3, 2024
Merged

1.1.7v #41

merged 8 commits into from
Dec 3, 2024

Conversation

suchencjusz
Copy link
Owner

@suchencjusz suchencjusz commented Dec 1, 2024

  • Fix tests
  • Fix docker
  • Remove codacy ci from tests

Dockerfile Improvements:

  • Switched base image to python:3.11-alpine and updated package installation commands in src/filman_crawler/Dockerfile, src/filman_discord/Dockerfile, and src/filman_server/Dockerfile. [1] [2] [3]

Documentation Update:

  • Added Codacy badge to README.md and reordered existing badges.

Logging and Error Handling:

  • Added DISCORD_TOKEN environment variable check and improved logging in src/filman_discord/main.py. [1] [2] [3]

Code Clean-up:

  • Removed commented-out code in src/filman_crawler/tasks/scrap_series.py.
  • Moved models.Base.metadata.create_all(bind=engine) to an earlier point in src/filman_server/main.py and improved logging. [1] [2] [3]

Testing Enhancements:

  • Added a comprehensive unit test for Discord database queries in tests/unit/tests_filman_server/database/tests_queries/test_discord.py.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.95%. Comparing base (a559a84) to head (ff4e205).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
src/filman_server/main.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   89.29%   87.95%   -1.35%     
==========================================
  Files          10       10              
  Lines         897      938      +41     
==========================================
+ Hits          801      825      +24     
- Misses         96      113      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suchencjusz suchencjusz self-assigned this Dec 2, 2024
@suchencjusz suchencjusz merged commit acc3591 into main Dec 3, 2024
5 of 8 checks passed
@suchencjusz suchencjusz deleted the 1.1.7v branch December 3, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant