Skip to content

Commit

Permalink
symlinks are bad idea, try empty files instead
Browse files Browse the repository at this point in the history
  • Loading branch information
paidforby committed May 22, 2018
1 parent 8f2215d commit cab7402
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion files/opt/mesh/config_succeeded
View file

This file was deleted.

Empty file added files/opt/mesh/config_succeeded
View file
Empty file.
1 change: 0 additions & 1 deletion files/opt/mesh/tunnel_hook
View file

This file was deleted.

Empty file added files/opt/mesh/tunnel_hook
View file
Empty file.

4 comments on commit cab7402

@bennlich
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what role do these empty files play?

@paidforby
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None at all. If you look at the previous two commits, daf3475 and 8f2215d, I had this idea that I would include symlinks as placeholders (so you knew the files were accounted for in the autoconf templates). However, this ended up breaking the autoconf script because those symlinks actually pointed to the template files and the node tried to use those template files as its real configuration.

Instead of symlinks, I just added empty files, but only for these two files, not sure my thinking there.

I have an idea for a much better way of setting up the pre-config files so they are almost identical to the templates. In fact, I think we should get rid of the template files completely, since they were just a hold over from makenode when I was trying to reduce the number of variables while porting it to shell. I would be more comfortable refactoring autoconf now that we know it is stable, I just haven't had time to dig into it. If you are interested working on that, I could give you a run down of how i think the autoconf script should work. Let me know.

@bennlich
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Maybe that would be a good entry / motivation for me to start building and working with the firmware more. Or maybe that is a terrible idea and I should steer clear of new ways to spend time. Hard to say :-P

But yeah I'm down to hear your ideas (in person or in a "template files refactor" github issue).

@paidforby
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you are comfortable to shell scripting and home node configs, it should be fairly simple. Would be great to see someone else contribute to the autoconf script, since we rely on it so heavily now. I opened issue #153 as you requested, but would be happy to talk through it with people during office hours tomorrow.

Please sign in to comment.