-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Undo and Redo functionality #26
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ravjot Singh <[email protected]>
Signed-off-by: Ravjot Singh <[email protected]>
Signed-off-by: Ravjot Singh <[email protected]>
Thanks.
@walterbender, please review? (You posted on issue #14). |
Signed-off-by: Ravjot Singh <[email protected]>
@quozl can you review this undo and redo button styles and i have resolved most of the suggestions as you mentioned sir |
You can find edit-undo.svg in sugar-artwork repository, icons/scalable/actions |
Signed-off-by: Ravjot Singh <[email protected]>
@quozl Undo and Redo button Updated according to sugar-artwork |
Thanks. @chimosky, @walterbender any review comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your commit message says "Implemented a stoke history data structure", I'm guessing you meant "stroke history".
If that's the case then you should edit the commit message.
Reviewed, not tested. I'm genuinely curios why you add lots of spaces in most of your commits, a commit message says one thing and after looking at the commit most of the changes are new line additions which is just noise. |
@chimosky This could be due to the linting tools configured in my setup, which might be automatically adjusting whitespace or adding new lines. I’ll review my configuration to ensure cleaner commits going forward. |
…ools Signed-off-by: Ravjot Singh <[email protected]>
@quozl if there are no further changes we should merge this pr |
#26 (comment) is my review of commit messages, no changes have happened yet. |
Add: Undo and Redo for pen stoke..
Undo-Redo.mp4