Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse print reserves for online resources #334

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Collapse print reserves for online resources #334

wants to merge 1 commit into from

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Jun 29, 2021 •
edited
Loading

Kapture 2021-06-29 at 10 40 13

TODO:

  • Is a semantic button triggering a collapse with a decorative checkbox side effect better or worse than a semantic checkbox with a collapse side effect? 🤷‍♂️
  • real language to use for that label
  • handle the no-print-reserves-needed case in the email

@cbeer cbeer requested a review from camillevilla June 29, 2021 17:44
Base automatically changed from 330-fall-crez to master July 6, 2021 14:29
@cbeer cbeer marked this pull request as ready for review July 6, 2021 14:30
@cbeer cbeer marked this pull request as draft July 6, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjgiarlo mjgiarlo mjgiarlo approved these changes

@camillevilla camillevilla Awaiting requested review from camillevilla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbeer @mjgiarlo