Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap 5 #569

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Bootstrap 5 #569

merged 1 commit into from
Aug 22, 2024

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Aug 21, 2024 •
edited
Loading

Fixes #554

@jcoyne jcoyne force-pushed the bootstrap5 branch 4 times, most recently from 573e055 to 2a881bf Compare August 21, 2024 16:06
@jcoyne jcoyne marked this pull request as ready for review August 21, 2024 16:07
@jcoyne jcoyne force-pushed the bootstrap5 branch 3 times, most recently from 38966a8 to f885364 Compare August 21, 2024 20:10
corylown
corylown requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@corylown corylown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There are a few text-right and form-group classes in the feedback form templates (app/views/shared/feedback_forms/_form.html.erb and in _reporting_from_html.erb) that should be text-end and mb-3 for BS5.

@jcoyne
Copy link
Contributor Author

jcoyne commented Aug 22, 2024

@corylown thank you for the review. I belive I have those resolved.

@corylown corylown merged commit 7cccac1 into main Aug 22, 2024
3 checks passed
@corylown corylown deleted the bootstrap5 branch August 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corylown corylown corylown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Bootstrap 5
2 participants
@jcoyne @corylown