Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rails 7.1 #1025

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Upgrade to rails 7.1 #1025

merged 1 commit into from
Jan 16, 2024

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jan 10, 2024

No description provided.

@jcoyne jcoyne force-pushed the rails71 branch 3 times, most recently from 6ecebdb to 0fa7fb6 Compare January 10, 2024 19:06
Copy link
Contributor

@corylown corylown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

Comment on lines 69 to 71
# Make sure URL helpers in emails work
config.action_mailer.default_url_options = { host: Settings.mailer_host, protocol: 'https' }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to retain this setting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@corylown corylown merged commit 5567310 into main Jan 16, 2024
3 checks passed
@corylown corylown deleted the rails71 branch January 16, 2024 22:39
@cbeer cbeer mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants