Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patrons should not inherit status from their sponsors in FOLIO #979

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Patrons should not inherit status from their sponsors in FOLIO #979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions app/models/folio/patron.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,7 @@ def university_id
end

def status
if proxy_borrower?
# proxy borrowers inherit from the group
group&.status
else
standing
end
standing
end

def standing
Expand All @@ -58,21 +53,11 @@ def standing
end

def barred?
# proxy borrowers inherit from the group
if proxy_borrower?
group.barred?
else
user_info['manualBlocks'].any?
end
user_info['manualBlocks'].any?
end

def blocked?
# proxy borrowers inherit from the group
if proxy_borrower?
group.blocked?
else
user_info['blocks'].any?
end
user_info['blocks'].any?
end

# From https://docs.folio.org/docs/users/: Inactive status indicates that the expiration date
Expand Down