Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Illiad requests into requests page #991

Merged
merged 15 commits into from
Oct 20, 2023
Merged

Integrate Illiad requests into requests page #991

merged 15 commits into from
Oct 20, 2023

Conversation

hudajkhan
Copy link
Contributor

@hudajkhan hudajkhan commented Oct 18, 2023 •
edited
Loading

Closes #300

What this pull request does:

  • Request ILLIAD transactions and include them in the list of requests associated with a patron. (These are all self requests and don't fall under any patron group related activities).
  • Show a "manage" link for ILLIAD transactions (instead of the change/cancel links) that links to the specific ILLIAD page for that request
  • ILLIAD transactions don't show any waitlist information
  • Use different fields for a scan ILLIAD transaction vs. a hold/recall ILLIAD transaction
  • Have the UI enable sorting in the same way as other regular requests
  • Added related tests

@hudajkhan hudajkhan marked this pull request as ready for review October 20, 2023 19:09
corylown
corylown requested changes Oct 20, 2023
View reviewed changes
app/models/illiad_requests.rb Outdated Show resolved Hide resolved
spec/controllers/requests_controller_spec.rb Outdated Show resolved Hide resolved
spec/models/illiad_requests_spec.rb Outdated Show resolved Hide resolved
spec/models/illiad_requests_spec.rb Outdated Show resolved Hide resolved
@corylown corylown merged commit a212b01 into main Oct 20, 2023
1 check passed
@corylown corylown deleted the listIlliad branch October 20, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corylown corylown corylown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration with ILLIAD
2 participants
@hudajkhan @corylown