Backfill missing versions in versions manifest. #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Aug 7, 2024
justinlittman
force-pushed
the
t907-missing_versions
branch
from
0b741d8 to
968d719
Compare
|
@justinlittman i've reversed myself from earlier. Since we want to show these "permanently withdrawn" versions on the purl page, we will need this. |
justinlittman
force-pushed
the
t907-missing_versions
branch
from
968d719 to
b0f5867
Compare
|
@jcoyne Fixed up and ready for review. |
jcoyne
requested changes
Aug 8, 2024
| "$schemaVersion" => 1, | ||
| 'head' => 3, | ||
| 'versions' => { | ||
| '1' => { 'state' => 'permanently_withdrawn' }, |
There was a problem hiding this comment.
There was a problem hiding this comment.
Can we change purl? DSA also uses permanently_withdrawn and it would be nice to be consistent across systems.
There was a problem hiding this comment.
Also, the original ticket specifies permanently_withdrawn: sul-dlss/purl#1101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #907