Remove Bootstrap 4 submit button #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-steve
force-pushed
the
range-limit-form-submit
branch
from
2639337 to
3c5092b
Compare
jcoyne
requested changes
Jun 21, 2024
| @@ -0,0 +1,9 @@ | |||
| <%= form_tag search_action_path, method: :get, class: [@classes[:form], "range_#{@facet_field.key} d-flex justify-content-center"].join(' ') do %> | |||
There was a problem hiding this comment.
Would you mind adding a comment above explaining why you've overridden this template?
There was a problem hiding this comment.
I don't mind, added.
taylor-steve
force-pushed
the
range-limit-form-submit
branch
from
3c5092b to
62b4004
Compare
jcoyne
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BS4 submit button from blacklight_range_limit is only visually hidden, it can still be tabbed to/is accessible to screen readers.