-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Feedback form #69
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple clarification questions.
@mailer_parser = FeedbackMailerParser.new(params, ip) | ||
|
||
mail(to: Settings.EMAIL_TO.FEEDBACK, | ||
subject: 'Feedback from SearchWorks', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "Bento" or something rather than SearchWorks?
|
||
mail(to: Settings.EMAIL_TO.FEEDBACK, | ||
subject: 'Feedback from SearchWorks', | ||
from: '[email protected]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here -- bento something rather than searchworks.stanford.edu?
Per convo in the courtyard, we might want to hold off on this to see how this might be affected by being proxied under library.stanford.edu |
Ok, I'll mark this as WIP |
Closes #41
Button stylin' dependent on #66