Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove pdfjs and use the native pdf viewer #1418

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Remove pdfjs and use the native pdf viewer #1418

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jan 12, 2023 •
edited
Loading

We don't need to ship a PDF library as this is now included in all browsers.
Test with:
https://embed-stage.stanford.edu/iframe?url=https://sul-purl-stage.stanford.edu/rr785jw7640
or https://sul-purl-stage.stanford.edu/cv071xh8846

Need to get buy in from stakeholders.

@jcoyne jcoyne force-pushed the without-pdfjs branch 4 times, most recently from e424c72 to 81bc9d8 Compare January 12, 2023 14:27
@jcoyne jcoyne force-pushed the without-pdfjs branch 3 times, most recently from fc645c2 to e35340b Compare February 9, 2023 17:25
@jcoyne jcoyne changed the title WIP Without pdfjs Remove pdfjs and use the native pdf viewer Feb 9, 2023
@jcoyne jcoyne marked this pull request as ready for review February 9, 2023 17:55
@cbeer
Copy link
Member

cbeer commented Feb 9, 2023 •
edited
Loading

I wonder whether we're concerned about:

  • inconsistent behavior, controls, and features in different browsers (e.g. Safari doesn't provide any controls beyond zoom and download)
  • some level of consistency between the different sul-embed viewers; this seems to get rid of the sul-embed chrome with various controls (download, attribution, etc)
  • whether the native chrome (which seems.. chunky) is appropriate in an embedded context
  • how (or whether?) the native chrome handles stanford-only, location-restricted or dark content

@jcoyne jcoyne marked this pull request as draft February 9, 2023 18:33
@jcoyne jcoyne changed the title Remove pdfjs and use the native pdf viewer [WIP] Remove pdfjs and use the native pdf viewer Feb 9, 2023
@lwrubel
Copy link
Contributor

lwrubel commented Oct 31, 2023

@thatbudakguy will talk with @cbeer about this to determine next steps if any.

@peetucket peetucket mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcoyne @cbeer @lwrubel