Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add auto-generated label to caption #2267

Merged
merged 1 commit into from
Dec 17, 2024
Merged

add auto-generated label to caption #2267

merged 1 commit into from
Dec 17, 2024

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Dec 4, 2024 •
edited
Loading

closes #2266
Screenshot 2024-12-05 at 5 01 24 PM

Screenshot 2024-12-05 at 12 58 50 PM

@dnoneill dnoneill force-pushed the auto-generated-captions branch 2 times, most recently from f438f7d to 6d2a598 Compare December 4, 2024 17:36
@alundgard
Copy link
Member

Could we move the dropdown language selector to its own line? (described in the original issue)
Also would it be possible to not wrap the label in the CC selector? Maybe that's a video.js constraint.

@dnoneill dnoneill changed the title add auto-generated label to caption READY FOR REVIEW: add auto-generated label to caption Dec 4, 2024
@dnoneill dnoneill force-pushed the auto-generated-captions branch from 6d2a598 to 22d5e20 Compare December 5, 2024 17:57
@dnoneill
Copy link
Contributor Author

dnoneill commented Dec 5, 2024

Oops. Missed that. Updated. And in answer to Also would it be possible to not wrap the label in the CC selector? Maybe that's a video.js constraint.. Not in a good way. I could make it not wrap but it is going to look weird with captions without auto-generated. We would basically need to add JS to fix this and it will be weird.

@dnoneill dnoneill marked this pull request as ready for review December 5, 2024 18:47
@dnoneill
Copy link
Contributor Author

dnoneill commented Dec 5, 2024

I was able to test this with a json locally that didn't contain sdrGeneratedText. It worked so I am more comfortable merging this.

@dnoneill dnoneill changed the title READY FOR REVIEW: add auto-generated label to caption add auto-generated label to caption Dec 5, 2024
@dnoneill dnoneill force-pushed the auto-generated-captions branch from 22d5e20 to 75e7789 Compare December 5, 2024 22:00
@dnoneill dnoneill mentioned this pull request Dec 16, 2024
Open
@peetucket peetucket merged commit c64ebda into main Dec 17, 2024
2 checks passed
@peetucket peetucket deleted the auto-generated-captions branch December 17, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peetucket peetucket peetucket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add auto-generated parenthetical to language selectors
3 participants
@dnoneill @alundgard @peetucket