Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix transcript sidebar for multiple media objects #2268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix transcript sidebar for multiple media objects #2268

wants to merge 1 commit into from

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Dec 4, 2024

closes #2257

@dnoneill dnoneill force-pushed the 2257-transcript-fix branch from ca68ba3 to 29c4cac Compare December 4, 2024 23:27
@dnoneill dnoneill force-pushed the 2257-transcript-fix branch 2 times, most recently from 94eb42b to 3c9ce95 Compare December 5, 2024 19:19
@dnoneill dnoneill requested a review from jcoyne December 9, 2024 22:53
@dnoneill dnoneill force-pushed the 2257-transcript-fix branch from 3c9ce95 to 0808d72 Compare December 16, 2024 16:56
@peetucket
Copy link
Member

@jcoyne any other concerns about this (after the conflict is fixed)?

@dnoneill dnoneill force-pushed the 2257-transcript-fix branch from 0808d72 to 67de72d Compare December 17, 2024 22:13
@jcoyne
Copy link
Contributor

jcoyne commented Dec 17, 2024

@peetucket I haven't had the bandwidth to look into this.

@peetucket
Copy link
Member

@peetucket I haven't had the bandwidth to look into this.

Thanks and no problems, just wanted to give you an opportunity to weigh in (since you previously reviewed) before we moved forward.

@dnoneill
Copy link
Contributor Author

dnoneill commented Dec 17, 2024 •
edited
Loading

@peetucket hold off on merging. auto-deploy is broken and I want to double check this works with multi-lingual items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peetucket peetucket peetucket approved these changes

@jcoyne jcoyne Awaiting requested review from jcoyne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dnoneill @peetucket @jcoyne