New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove :name from library spec data to match API response #1886

Merged

jcoyne merged 1 commit into main from instance-spec

Oct 2, 2023

Contributor

corylown commented Oct 2, 2023

:name was added to the spec data in 79411dd#diff-e769bbb8c1ba3711c5403b424ed9c218ffafba7f1890ee394717196f28ff4540 but the response we get from the graphql request for an instance does not include library name: https://github.com/sul-dlss/sul-requests/blob/main/app/services/folio_graphql_client.rb#L133


          Remove :name from library spec data to match API response

f7c417e

jcoyne approved these changes

View reviewed changes

jcoyne merged commit 64fa7ad into main

1 check passed

jcoyne deleted the instance-spec branch

October 2, 2023 16:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet