Merge pull request #145 from sul-dlss/pubmedclient-fix

use pubmed client when looking up records at pubmed to ensure HTTPS c…
sul-dlss · Nov 10, 2016 · f480952 · f480952
2 parents 2e60914 + ac31d29
commit f480952
Show file tree

Hide file tree

Showing 17 changed files with 8,565 additions and 6 deletions.
diff --git a/app/models/pubmed_source_record.rb b/app/models/pubmed_source_record.rb
@@ -47,13 +47,8 @@ def self.create_pubmed_source_record(pmid, pub_doc)
 
   def self.get_and_store_records_from_pubmed(pmids)
     pmidValuesForPost = pmids.collect { |pmid| "&id=#{pmid}" }.join
-    http = Net::HTTP.new('eutils.ncbi.nlm.nih.gov')
-    request = Net::HTTP::Post.new('/entrez/eutils/efetch.fcgi?db=pubmed&retmode=xml')
-    request.body = pmidValuesForPost
+    the_incoming_xml = PubmedClient.new.fetch_records_for_pmid_list pmidValuesForPost
 
-    # http.start
-    the_incoming_xml = http.request(request).body
-    # http.finish
     count = 0
     source_records = []
     Nokogiri::XML(the_incoming_xml).xpath('//PubmedArticle').each do |pub_doc|

diff --git a/...cr_cassettes/PubmedSourceRecord/_get_pubmed_record_from_pubmed/extracts_fields_-_pmid.yml b/...cr_cassettes/PubmedSourceRecord/_get_pubmed_record_from_pubmed/extracts_fields_-_pmid.yml
diff --git a/...SourceRecord/_get_pubmed_record_from_pubmed/returns_an_instance_of_PubmedSourceRecord.yml b/...SourceRecord/_get_pubmed_record_from_pubmed/returns_an_instance_of_PubmedSourceRecord.yml