Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for excluding templates in Sulu 2.x #809

Merged

Conversation

mcoiffier
Copy link
Contributor

Q A
Fixed tickets fixes #888
License MIT

What's in this PR?

Removal of the caution regarding the visibility of templates in the dropdown list.

Why?

Because since version 2.x of Sulu, this is no longer the case. You need to use the excluded-templates node in the webspace file.

Comment on lines 43 to 48
.. Caution::

A template is shown in the dropdown only if both the XML and the Twig file
exist! If you can't see your template, double-check the directories
``config/templates/pages`` and ``templates/pages``.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a info or hint for the excluded part in the webspace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, what do you think about this commit 3c5641b?

@alexander-schranz alexander-schranz changed the base branch from 2.x to 2.5 June 25, 2024 12:11
@alexander-schranz alexander-schranz force-pushed the fix/exclude-templates-management branch from 3c5641b to d4b5503 Compare June 25, 2024 12:12
@alexander-schranz alexander-schranz merged commit 61be3cc into sulu:2.5 Jun 25, 2024
1 check passed
@alexander-schranz
Copy link
Member

@mcoiffier Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of the caution regarding template visibility in the template selection dropdown
2 participants