Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analytics template path #823

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix analytics template path #823

merged 1 commit into from
Nov 28, 2024

Conversation

fnagel
Copy link

@fnagel fnagel commented Nov 28, 2024

@alexander-schranz
Copy link
Member

Thank you can we use the more modern syntax with / instead of : and can you rebase and target the 2.5 branch?

@fnagel
Copy link
Author

fnagel commented Nov 28, 2024

Changed the code, but unsure if I did right with the branch as there is that "This branch is out-of-date with the base branch" note form Github.

@fnagel
Copy link
Author

fnagel commented Nov 28, 2024

Maybe I need to close this one and create a new one like this: https://github.com/sulu/sulu-docs/compare/2.5...fnagel:sulu-docs:patch-1?expand=1

@alexander-schranz alexander-schranz changed the base branch from 2.x to 2.5 November 28, 2024 17:29
@alexander-schranz alexander-schranz enabled auto-merge (squash) November 28, 2024 17:30
@alexander-schranz
Copy link
Member

@fnagel looks good. Thank you!

@alexander-schranz alexander-schranz merged commit 17807b1 into sulu:2.5 Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants