Add rector ruleset for Sulu 3.0

composer.json

@@ -9,7 +9,7 @@
     ],
     "require": {
         "php": "^8.1",
-        "rector/rector": "^0.14.1 || ^0.15"
+        "rector/rector": "^0.15"
     },
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.6",
@@ -20,7 +20,7 @@
         "phpstan/phpstan-strict-rules": "^1.2",
         "phpstan/phpstan-webmozart-assert": "^1.1",
         "phpunit/phpunit": "^9.5.20",
-        "sulu/sulu": "^2.5@dev",
+        "sulu/sulu": "^2.5@dev || ^3.0@dev",
         "thecodingmachine/phpstan-strict-rules": "^1.0"
     },
     "autoload": {
@@ -61,7 +61,8 @@
         "allow-plugins": {
             "rector/extension-installer": true,
             "cweagans/composer-patches": true,
-            "phpstan/extension-installer": true
+            "phpstan/extension-installer": true,
+            "php-http/discovery": true
         }
     }
 }

config/sets/sulu/level/up-to-sulu-30.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Sulu\Rector\Set\SuluLevelSetList;
+use Sulu\Rector\Set\SuluSetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->sets([SuluSetList::SULU_30, SuluLevelSetList::UP_TO_SULU_25]);
+};

config/sets/sulu/sulu-30.php

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Renaming\Rector\MethodCall\RenameMethodRector;
+use Rector\Renaming\ValueObject\MethodCallRename;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->ruleWithConfiguration(
+        RenameMethodRector::class,
+        [
+            // @see https://github.com/sulu/sulu/pull/7053
+            new MethodCallRename(
+                'Sulu\Component\Webspace\Portal',
+                'getXDefaultLocalization',
+                'getDefaultLocalization',
+            ),
+            // @see https://github.com/sulu/sulu/pull/7053
+            new MethodCallRename(
+                'Sulu\Component\Webspace\Portal',
+                'setXDefaultLocalization',
+                'setDefaultLocalization',
+            ),
+            // @see https://github.com/sulu/sulu/pull/7053
+            new MethodCallRename(
+                'Sulu\Component\Localization\Localization',
+                'isXDefault',
+                'isDefault',
+            ),
+            // @see https://github.com/sulu/sulu/pull/7053
+            new MethodCallRename(
+                'Sulu\Component\Security\Event\PermissionUpdateEvent',
+                'getSecurityIdentity',
+                'getPermissions',
+            ),
+        ],
+    );
+};

src/Set/SuluLevelSetList.php

@@ -17,4 +17,9 @@ final class SuluLevelSetList implements SetListInterface
      * @var string
      */
     final public const UP_TO_SULU_25 = __DIR__ . '/../../config/sets/sulu/level/up-to-sulu-25.php';
+
+    /**
+     * @var string
+     */
+    final public const UP_TO_SULU_30 = __DIR__ . '/../../config/sets/sulu/level/up-to-sulu-30.php';
 }

src/Set/SuluSetList.php

@@ -17,4 +17,9 @@ final class SuluSetList implements SetListInterface
      * @var string
      */
     final public const SULU_25 = __DIR__ . '/../../config/sets/sulu/sulu-25.php';
+
+    /**
+     * @var string
+     */
+    final public const SULU_30 = __DIR__ . '/../../config/sets/sulu/sulu-30.php';
 }

tests/Set/Sulu25/Sulu25Test.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Sulu\Rector\Tests\Set\Sulu24;
+namespace Sulu\Rector\Tests\Set\Sulu25;
 
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;

tests/Set/Sulu30/Fixture/permission_update_event_get_security_identity_to_get_permissions.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+namespace Sulu\Rector\Tests\Set\Sulu30\Fixture;
+
+class PermissionUpdateEventGetSecurityIdentityToGetPermissions {
+    public function getDefaultLocalization(\Sulu\Component\Security\Event\PermissionUpdateEvent $event): string
+    {
+        return $event->getSecurityIdentity();
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Sulu\Rector\Tests\Set\Sulu30\Fixture;
+
+class PermissionUpdateEventGetSecurityIdentityToGetPermissions {
+    public function getDefaultLocalization(\Sulu\Component\Security\Event\PermissionUpdateEvent $event): string
+    {
+        return $event->getPermissions();
+    }
+}
+
+?>

tests/Set/Sulu30/Fixture/portal_localization_xdefault_to_default.php.inc

@@ -0,0 +1,45 @@
+<?php
+
+namespace Sulu\Rector\Tests\Set\Sulu30\Fixture;
+
+class PortalLocalizationXDefaultToDefault {
+    public function getDefaultLocalization(\Sulu\Component\Webspace\Portal $portal): string
+    {
+        return $portal->getXDefaultLocalization();
+    }
+
+    public function setDefaultLocalization(\Sulu\Component\Webspace\Portal $portal, \Sulu\Component\Localization\Localization $localization): void
+    {
+        $portal->setXDefaultLocalization($localization);
+    }
+
+    public function isDefault(\Sulu\Component\Localization\Localization $localization): string
+    {
+        return $localization->isXDefault();
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Sulu\Rector\Tests\Set\Sulu30\Fixture;
+
+class PortalLocalizationXDefaultToDefault {
+    public function getDefaultLocalization(\Sulu\Component\Webspace\Portal $portal): string
+    {
+        return $portal->getDefaultLocalization();
+    }
+
+    public function setDefaultLocalization(\Sulu\Component\Webspace\Portal $portal, \Sulu\Component\Localization\Localization $localization): void
+    {
+        $portal->setDefaultLocalization($localization);
+    }
+
+    public function isDefault(\Sulu\Component\Localization\Localization $localization): string
+    {
+        return $localization->isDefault();
+    }
+}
+
+?>

tests/Set/Sulu30/Sulu30Test.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Sulu\Rector\Tests\Set\Sulu30;
+
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Symplify\SmartFileSystem\SmartFileInfo;
+
+final class Sulu30Test extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(string $fileInfo): void
+    {
+        $this->doTestFile($fileInfo);
+    }
+
+    /**
+     * @return \Iterator<SmartFileInfo>
+     */
+    public function provideData(): \Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/sulu-30.php';
+    }
+}

tests/Set/Sulu30/config/sulu-30.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Sulu\Rector\Set\SuluSetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->import(__DIR__ . '/../../../../config/config.php');
+    $rectorConfig->sets([SuluSetList::SULU_30]);
+};