Modal Component #2795
Open
Modal Component #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90fc87c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +6.83 kB (+1.02%) Total Size: 678 kB
ℹ️ View Unchanged
|
sirineJ
force-pushed
the
feat/dialog-component
branch
from
2923b4c to
2b00b81
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
2b00b81 to
ddb9966
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
5b67511 to
7b1cc74
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2795 +/- ##
==========================================
+ Coverage 87.75% 87.83% +0.08%
==========================================
Files 221 225 +4
Lines 12746 13004 +258
Branches 1730 1776 +46
==========================================
+ Hits 11185 11422 +237
- Misses 1506 1528 +22
+ Partials 55 54 -1
|
sirineJ
force-pushed
the
feat/dialog-component
branch
from
7b1cc74 to
4a08192
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
4a08192 to
16d765e
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
cbc7308 to
dc6e5f0
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
dc6e5f0 to
6b2ccd8
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
bb7c9a2 to
adc0e75
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
2 times, most recently
from
aac8f8e to
7943586
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
1271e93 to
0c7f118
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
0c7f118 to
bf25916
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
bf25916 to
a56459a
Compare
|
/preview |
connor-baer
approved these changes
Dec 23, 2024
|
/preview |
|
/preview |
sirineJ
force-pushed
the
feat/dialog-component
branch
from
e982a3d to
5266f90
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
5266f90 to
95af0e8
Compare
sirineJ
force-pushed
the
feat/dialog-component
branch
from
95af0e8 to
90fc87c
Compare
sirineJ
added
preview
and removed
preview
disable-chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-860.
Purpose
Rewrite the modal component using the native HTML
<dialog/>element with thedialog-polyfillApproach and changes
react-modaland use the<dialog/>element in the modal component.useModalhook.Definition of done