Optimize Coverage Exclusion #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 670 kB ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
==========================================
- Coverage 87.90% 87.75% -0.16%
==========================================
Files 218 221 +3
Lines 12724 12746 +22
Branches 1727 1730 +3
==========================================
Hits 11185 11185
- Misses 1487 1506 +19
- Partials 52 55 +3 |
sirineJ
force-pushed
the
exclude-translation-files-from-vite-coverage
branch
from
6a4abb4 to
404a752
Compare
sirineJ
force-pushed
the
exclude-translation-files-from-vite-coverage
branch
from
404a752 to
45bb11d
Compare
sirineJ
changed the title
connor-baer
reviewed
Dec 17, 2024
sirineJ
force-pushed
the
exclude-translation-files-from-vite-coverage
branch
from
45bb11d to
0c45cf4
Compare
sirineJ
force-pushed
the
exclude-translation-files-from-vite-coverage
branch
from
0c45cf4 to
e01cc3a
Compare
connor-baer
reviewed
Dec 17, 2024
sirineJ
force-pushed
the
exclude-translation-files-from-vite-coverage
branch
from
e01cc3a to
02325bf
Compare
connor-baer
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Following the addition of translations in CUI, translation files should be excluded from vite coverage.
Approach and changes
Add pattern for excluding translation files to the vite config.
Exclude css modules.
Fix pattern for dist/ folders
Definition of done