Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new sunpy package template #1

Merged
merged 9 commits into from
Mar 19, 2020
Merged

A new sunpy package template #1

merged 9 commits into from
Mar 19, 2020

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Mar 19, 2020

No description provided.

@Cadair Cadair requested a review from nabobalis March 19, 2020 17:20
@@ -6,13 +6,15 @@
"author_email": "",
"license": ["BSD 3-Clause", "GNU GPL v3+", "Apache Software License 2.0", "BSD 2-Clause", "Other"],
"project_url": "",
"minimum_python_version": ["3.7", "3.6", "3.5"],
"github_repo": "sunpy/{{ cookiecutter.package_name }}",
"minimum_python_version": ["3.8", "3.7", "3.6", "3.5"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 3.5 worth it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have kept it because people might have old packages they haven't updated yet

Continuous Integration
======================

Needs writing!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still not want something on the CI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to document our specifics yes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably open an issue so we don't forget.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

# project-wide pinning of dependencies, e.g. if new versions of pytest do not
# work correctly with pytest-astropy plugins. Most of the time the pinnings file
# should be empty.
pypi_filter_requirements = https://raw.githubusercontent.com/sunpy/package_template/master/sunpy_version_pins.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this pinned in the package_template repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean why have I put this file here?

I put it here because it feels like everyone using this repo would be using it. We could also put it in core?

Copy link
Contributor

@nabobalis nabobalis Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just seems a bit odd to me that if we have to pin a test dep, we have to go to this repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, put it in core?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if core makes any more sense. I don't really have any bright ideas at the moment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will open an issue.

@Cadair Cadair merged commit a56a138 into sunpy:master Mar 19, 2020
@Cadair Cadair deleted the sunpy branch March 19, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants