Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TokenRequest json code to auth_code #6

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

akmalcm
Copy link
Contributor

@akmalcm akmalcm commented Sep 29, 2024

What kind of change does this PR introduce?

  • Change TokenRequest json code to auth_code
  • Improve ErrInvalidTokenRequest message to include PKCE grant_type

What is the current behavior?

Issue #5

TokenRequest is passing code to Supabase Auth, however current implementation it is accepting auth_code

How Supabase Auth handle PKCE params

What is the new behavior?

TokenRequest will pass auth_code to Supabase Auth

Copy link
Collaborator

@kwoodhouse93 kwoodhouse93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, change looks good!

@kwoodhouse93 kwoodhouse93 merged commit 71a76d8 into supabase-community:main Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants