Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autovalidation and remove hardcoded styling from checkboxes #125

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

bcorman
Copy link
Contributor

@bcorman bcorman commented Oct 11, 2024

  • Add autoFormValidation to MetaDataField (fixes MetaDataField needs autoValidation to match email/password field functionality #123)

    Fixes issue where form could submit with MetaDataField in an invalid state. New behavior matches that of password and email fields.

  • Remove hardcoded styling for BooleanMetaDataField to prevent it from overriding an app's ThemeData (fixes Remove border outline from BooleanMetaDataField #124)

    Fixes issue where border outlines would always appear. New behavior leaves styling up to ThemeData. If users of this library request it, we could potentially add these back as parameters for BooleanMetaDataField to pass down to its child CheckboxListTile, but that doesn't seem necessary for now.

Remove hardcoded styling for BooleanMetaDataField to
prevent it from overriding an app's ThemeData
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this amazing update! Will publish a new version right after!

@dshukertjr dshukertjr merged commit 538f7c4 into supabase-community:main Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants