-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add MFA for WebAuthn bindings #960
Open
J0
wants to merge
2
commits into
master
Choose a base branch
from
j0/add_webauthn
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
commented
Sep 19, 2024
J0
commented
Oct 2, 2024
J0
commented
Oct 2, 2024
J0
commented
Oct 2, 2024
J0
commented
Oct 2, 2024
J0
commented
Oct 3, 2024
J0
commented
Oct 3, 2024
hf
reviewed
Oct 5, 2024
hf
reviewed
Oct 5, 2024
hf
reviewed
Oct 5, 2024
hf
reviewed
Oct 5, 2024
hf
reviewed
Oct 5, 2024
hf
reviewed
Oct 5, 2024
hf
reviewed
Oct 5, 2024
hf
reviewed
Oct 5, 2024
hf
reviewed
Oct 5, 2024
hf
reviewed
Oct 5, 2024
hf
reviewed
Oct 10, 2024
hf
reviewed
Oct 10, 2024
hf
reviewed
Oct 10, 2024
J0
commented
Nov 13, 2024
|
||
export type MFAVerifySingleStepWebAuthnParams = { | ||
factorId: string | ||
challengeId: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
challengeId: string | |
challengeId?: string |
J0
commented
Nov 28, 2024
return { data, error: null } | ||
} | ||
const factorId = data.id | ||
const webAuthn = this._getWebAuthnRpDetails() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should pre-emptively check if web-authn is supported here and return an error if not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We introduce bindings for MFA (WebAuthn) which consists of primary methods and helper methods.
Core Methods
The core methods have single step and multi-step use. A single step enroll handles the browser interactions for you while the multi-step enroll provides one the freedom to configure options as they wish.
For enrollment single step looks like:
While mutli-step enroll contains a webAuthn parameter than can be customized
Verify operates in a similar fashion.
There are two methods,
challenge
andchallengeAndVerify
which are affected.Helper methods
We provide the following helper methods for ease of use:
browserSupportsWebAuthn
- most modern browsers should support the WebAuthn specification.startRegistration
- this method takes reference from SimpleWebAuthn and wrapsnavigator.create
. Use this to customize how a credential is createdstartAuthentication
- this methods takes reference from SimpleWebAuthn and wrapsnavigator.get
. Use this to customize how a credential is retrieved