Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare major release #553

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

m-shaka
Copy link
Collaborator

@m-shaka m-shaka commented Jul 14, 2024

  • specified engines.node(>=18)
  • introduced changeset to automate the release process

If a PR including a changeset file is merged, the release workflow(release.yml) will create a PR to release a new version. What changeset does there is:

  • write CHANGELOG.md based on changeset files
  • remove changeset files
  • rewrite version field of package.json

Also, in the release process, changeset will write a release note of GitHub release page

@m-shaka m-shaka force-pushed the specify-engines-field branch from 6c9abec to c102b0d Compare July 14, 2024 06:49
@m-shaka m-shaka changed the title chore: upgrade deps support Node.js >= 18 Jul 14, 2024
@m-shaka m-shaka changed the title support Node.js >= 18 prepare major release Jul 15, 2024
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the file called chilled-pugs-knock? 😆

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a randomly generated name. Sometimes funny 😆

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: b733676

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
neverthrow Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@m-shaka m-shaka marked this pull request as ready for review July 17, 2024 01:42
id: changesets
uses: changesets/action@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to create a release PR

- name: Release
run: npm run release
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to release


release:
needs: create_pr
if: needs.create_pr.outputs.hasChangesets == 'false'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supermacro supermacro merged commit 34b513f into supermacro:master Jul 17, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants