Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update watcher #1888

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maryamtahhan
Copy link
Collaborator

@maryamtahhan maryamtahhan commented Dec 9, 2024

Update the watcher implementation to use NewTypedRateLimitingQueue and fix the linting issue @ #1852

@maryamtahhan maryamtahhan marked this pull request as ready for review December 9, 2024 09:09
@maryamtahhan maryamtahhan marked this pull request as draft December 9, 2024 09:09
Copy link
Contributor

github-actions bot commented Dec 9, 2024

🤖 SeineSailor

Here's a concise summary of the pull request changes:

Summary: This pull request updates the Go version to 1.22.0, toolchain to go1.22.3, and bumps dependencies to their latest versions, including k8s.io/api, k8s.io/apimachinery, and k8s.io/client-go. The changes introduce two new dependencies, github.com/fxamacker/cbor/v2 and github.com/x448/float16, and modify the watcher implementation to utilize NewTypedRateLimitingQueue. Additionally, the updates include modifications to the ByteString type, new functions and types for encoding and decoding CBOR data, and updates to k8s.io/api packages with new API objects and deep copy functions.

Key Modifications:

  1. Go version and toolchain updates: The Go version is updated to 1.22.0, and the toolchain is updated to go1.22.3, ensuring the codebase is compatible with the latest Go features and security patches.
  2. Dependency updates: The k8s.io/api, k8s.io/apimachinery, and k8s.io/client-go dependencies are updated to their latest versions (v0.31.3), which may include bug fixes, performance improvements, and new features.
  3. New dependencies: The introduction of github.com/fxamacker/cbor/v2 and github.com/x448/float16 dependencies may provide new functionality for encoding and decoding CBOR data and working with floating-point numbers.
  4. Watcher implementation updates: The watcher implementation is modified to utilize NewTypedRateLimitingQueue, which may improve performance and reliability.
  5. k8s.io/api package updates: The updates include new API objects related to ValidatingAdmissionPolicy and its bindings, as well as deep copy functions for several struct types, which may enhance the codebase's interaction with Kubernetes resources.

Observations and Suggestions:

  • The updates to the Go version and toolchain may require additional testing to ensure compatibility with existing code and dependencies.
  • The introduction of new dependencies may require additional documentation and testing to ensure their correct usage and integration with the codebase.
  • The modifications to the watcher implementation and k8s.io/api packages may require additional testing to ensure their correctness and performance.
  • It would be beneficial to include a detailed changelog or release notes to highlight the impact of these changes on the codebase and its users.

Signed-off-by: Maryam Tahhan <[email protected]>
@maryamtahhan maryamtahhan marked this pull request as ready for review December 9, 2024 10:12
Copy link
Collaborator

@SamYuan1990 SamYuan1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please hold on for merge as it contains k8s api version bump up. @rootfs, as far as I can remember, we take care for any dep version bump up as it contains k8s api?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants