Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svalboard: dual pointer default now. #30

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

ilc
Copy link
Collaborator

@ilc ilc commented Apr 28, 2024

People are getting confused by left hand scroll by default.

Fixing it.

People are getting confused by left hand scroll by default.

Fixing it.
@ilc
Copy link
Collaborator Author

ilc commented Apr 28, 2024

ok, the branch is misnamed. It is right.

@morganvenable
Copy link

Okay so I tweaked the global check to make sure it ran on =1 and got it to flash default mouse ball on left, but I'm not totally clear about the intended functionality here.

Shouldn't we want the whole EEPROM to just be overwritable with fresh image? Like as a customer, I expect that if I reflash, I get a clean version with the clean defaults -- same as if I reflash L/R sides with different handedness, I want that to just work?

Or is the concept here that reflash leaves Vial EEPROM intact for less pain in reloading it as a user?

@ilc
Copy link
Collaborator Author

ilc commented Apr 29, 2024

QMK leaves what you put in the eeprom alone across flashes.

So people who have the issue TODAY, this will not help, unless we bump the version and force set the attribute. But the intent of setting versions was to allow for expansion of our use of the eeprom in the future, because I saw no need to erase them it our case.

If we want to do that, we should talk.

Copy link

@morganvenable morganvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@morganvenable morganvenable merged commit 8d59f00 into svalboard:vial Apr 29, 2024
10 checks passed
@ilc ilc deleted the dual-scroll-default branch May 10, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants