-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace booleans with dark
| light
strings
#10
Conversation
🦋 Changeset detectedLatest commit: 0564701 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to do this! Just a few minor things, mostly naming-related but one regarding an export. If you have any questions feel free to hit me up on Discord or if you want me to take care of this last bit, let me know and I can certainly do so!
I think I fixed it all now, let me know if I missed anything. tests are passing and my test app is also working |
Incredible, thanks a ton @ollema! |
I could not get #9 to work - ran into some very weird issues.
This patch changes less things, and now all tests pass and it works for apps as well, as far as I can tell.
In this patch:
getModeUserPrefers
,getModeAutoPrefers
,autoModeWatcher
)localStorage
keys) are renamed, mostly to ensure that there are no unforeseen consequences for end users when persistent stores are changed from booleans to stringsAll in all, I hope this patch will improve readability