add track prop to track changes in system preference
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2bb9d31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
also, would be cool to add some tests for this but I could not figure out how to change maybe emitting |
huntabyte
approved these changes
Oct 28, 2023
|
Yeah, I'll look into emitting the event to get it tested! Thanks again for your efforts here! |
huntabyte
changed the title
track prop which allows <ModeWatcher> to track changes in system preferencetrack prop to track changes in system preference
|
FYI @shyakadavis this is released now! let me know if you run into any issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
trackis set totrue(default),mode-watcherwill add an event listener to the media query event and update the mode wheneverprefers-color-schemeis changed.trackbeing set totruecould be considered as a breaking change? I view it more as a bug fix. therefore I marked it is patch. what do you think @huntabyte?will close #13